Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sparse checkout support #30

Merged
merged 3 commits into from
Jan 12, 2014
Merged

Added sparse checkout support #30

merged 3 commits into from
Jan 12, 2014

Conversation

Tetradeus
Copy link

Hi,

Here is my implementation of "Git Sparse Checkout" for CliGitApi.
http://git-scm.com/docs/git-read-tree

The implementation does not seem available yet in JGIT.

"Git Sparse Checkout" feature is really useful when dealing with multi-project Git repository.
It can indeed save a lot of space.
http://stackoverflow.com/questions/10791472/jenkins-and-git-sparse-checkouts

I also have a pull request for Jenkins Git Plugin that enables "Git Sparse Checkout". I will propose it if this one is merged.

Regards,

Thomas

@cloudbees-pull-request-builder

plugins » git-client-plugin #121 UNSTABLE
Looks like there's a problem with this pull request

@Tetradeus
Copy link
Author

retrieveSparseCheckoutPaths() in GitClient is just an helpful method to know if git sparse checkout is active and what are the impacted paths.
This method can indeed be removed without impacting this feature.
This is up to you.

I will move sparseCheckout() in CheckoutCommand in CliGitAPIImpl

Thomas

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@ndeloof
Copy link
Contributor

ndeloof commented Oct 18, 2013

I'd prefer not to expose such very-specific method in GitClient, especially when not supported by JGit.
If unnecessary from git-plugin please remove it.

@cloudbees-pull-request-builder

plugins » git-client-plugin #124 SUCCESS
This pull request looks good

@Tetradeus
Copy link
Author

Hello Ndeloof,

Are you looking for any more review ?

Thanks,

Thomas

@ndeloof
Copy link
Contributor

ndeloof commented Nov 4, 2013

I'm focussing on fixing remaining bugs in 1.4.x branch at this time, mostly in a "feature-freeze" mode. I will review this asap

ndeloof added a commit that referenced this pull request Jan 12, 2014
@ndeloof ndeloof merged commit a00dff2 into jenkinsci:sparse-checkout Jan 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants