Improve "Build triggered/started" messages #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wjt you appear to be updating the message without updating tests. So the tests which are looking for specific phrases are failing to pass. Please update the tests as well. In general, I'm okay with rephrasing this as I agree it's a bit confusing as is. |
Previously, the messages were:
> Build triggered. sha1 is {merged,original commit}.
and, sic lack of full stop between the two sentences:
> Build started sha1 is {merged,original commit}.
Make these consistent, and clearer:
> Build {triggered,started} for {merge,original} commit.
and update the tests accordingly.
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this pull request
Dec 12, 2018
Improve "Build triggered/started" messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the messages were "Build triggered sha1 is {merged,original
commit}." (note the lack of full-stop after "triggered") and "Build
started. sha1 is {merged,original commit}.". Make these consistent, and
make the message clearer: "Build {triggered,started} for
{merge,original} commit."