Skip to content

[JENKINS-74929] Unable to clear the Aborted checkbox for Skip Vote #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alexandoooor
Copy link

@Alexandoooor Alexandoooor commented Mar 30, 2025

Change the Skip vote on aborted checkbox to be checked if onAborted is true, instead of if onNotBuilt is true.

The checkbox for skip on aborted wrongly controlled the filed onNotBuilt instead of onAborted. My pull request fixes this so that it points to onAborted.

Testing done

I ran mvn clean package, mvn findbugs:findbugs and mvn checkstyle:checkstyle

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Change the Skip vote on aborted checkbox to be checked if onAborted is
true, instead of if onNotBuilt is true.
@panicking
Copy link
Contributor

@rsandell are you going to review this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants