Upgrade to use jcasc test harness #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetersen
approved these changes
Jan 19, 2020
res0nance
approved these changes
Jan 30, 2020
res0nance
approved these changes
Jan 30, 2020
AbhyudayaSharma
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
This looks like a great improvement to JCasC. I will not ping Oleg about it because he is busy at the moment but this looks safe to merge because this was done to role strategy as well. @timja You would need a release right?
Co-Authored-By: Raihaan Shouhell <raihaanhimself@gmail.com>
would be good. |
AbhyudayaSharma
added
the
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JCasc had to create a new dependency that wasn't a
testsclassifier because maven doesn't allow you to bring dependencies through classifiers.Upgrading here so that PCT works again,
Tracking:
jenkinsci/bom#164
Note: We'll need a release for PCT please
Closes #46