Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic authentication #158

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

strangelookingnerd
Copy link
Contributor

Fixes #157

The authentication must be initiated pre-emptively with httpclient5 to work properly.

Testing done

Added tests for downloading files with and without authorization as well as bad credentials.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner March 7, 2025 15:06
@jonesbusy jonesbusy merged commit f3b9baf into jenkinsci:main Mar 7, 2025
17 checks passed
@jonesbusy
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fileDownloadOperation fails when used with credentials
2 participants