Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to httpclient5 #156

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

strangelookingnerd
Copy link
Contributor

Replaces outdated httpclient4 with the successor httpclient5.

Testing done

mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner February 26, 2025 09:18
@jonesbusy jonesbusy self-assigned this Feb 26, 2025
@jonesbusy
Copy link
Contributor

@strangelookingnerd Thanks! Were you able to perform some interactive tests?

I'm afraid this plugin lack of integration tests and missing coverage

If not I will try to perform quick tests soon

@strangelookingnerd
Copy link
Contributor Author

I set up a simple job with FileDownloadOperation to download something from a simple webserver. It did not crash so I was satisfied, however there was no authentication or redirects involved.

@jonesbusy jonesbusy merged commit f46cd3e into jenkinsci:main Feb 26, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants