Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for FolderRenameOperation #113

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Add Tests for FolderRenameOperation #113

merged 1 commit into from
Jul 28, 2024

Conversation

ivamly
Copy link
Contributor

@ivamly ivamly commented Jul 28, 2024

Add Tests for FolderRenameOperation

Description

This pull request introduces a set of additional tests for the FolderRenameOperation class, significantly increasing test coverage and ensuring the reliability of the file joining functionality. Enhanced the coverage of the FolderRenameOperation class from 25% to 87%.

Related Issues

#74

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ivamly ivamly requested a review from a team as a code owner July 28, 2024 08:12
@jonesbusy
Copy link
Contributor

Thanks a lot for those tests!

@jonesbusy jonesbusy merged commit 3521baf into jenkinsci:main Jul 28, 2024
16 checks passed
@ivamly
Copy link
Contributor Author

ivamly commented Jul 28, 2024

@jonesbusy, thank you very much for your feedback! I’m glad you found the tests helpful. I plan to write additional tests to cover more of the classes that are currently under-tested. If you have any further advice or recommendations, I’d be happy to hear them and would appreciate any guidance you can provide.

@ivamly ivamly deleted the FoldRenameTests branch July 28, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants