Use rangeMin
and rangeMax
in all charts if defined in model (instead of using dataMin
by default)
#236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using rangeMin and rangeMax from chartModel instead of using 'dataMin' by default in yAxis in configurable-trend-chart.js and trend-chart.js.
I have already submitted an issue in the echarts-build-trends repository. I have looked at this again more closely and find out, that the rangeMin and rangeMax property is ignored for the configurable trend charts.
I tested the changes locally and using the following setup now:
and setting the model with:
Result:
The same problem was observed for the pre defined job trend charts. I also updated the js file for the trend-result.
Result: