Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copy_reference_file quieter #89

Merged
merged 4 commits into from
Apr 29, 2015
Merged

Make copy_reference_file quieter #89

merged 4 commits into from
Apr 29, 2015

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 27, 2015

Produces way too much output if you have a lot of files in /usr/share/jenkins/ref. @reviewbybees

Produces way too much output if you have a lot of files in `/usr/share/jenkins/ref`. @reviewbybees
@ndeloof
Copy link
Contributor

ndeloof commented Apr 27, 2015

but this is useful to diagnose bootstrap issues. Could maybe support some -q flag (or add -verbose) to disable output

@jglick
Copy link
Member Author

jglick commented Apr 27, 2015

I think it should be quiet by default. If you need to diagnose anything, these messages could be written to a log file inside the container.

@ndeloof
Copy link
Contributor

ndeloof commented Apr 27, 2015

docker practice is to send logs to stdout, so that docker log can collect them. Don't use log files inside container

@jglick
Copy link
Member Author

jglick commented Apr 27, 2015

Well it is just too much noise for something you do not normally want to look at, when as a user you are interested in the Jenkins log, not some file copying inside the container. It is only because of the VOLUME trick that this copying even happens at runtime; normally this sort of thing would be part of docker-build.

@ndeloof
Copy link
Contributor

ndeloof commented Apr 28, 2015

sure, but jenkins design to merge config and plugin files in jenkins_home doens't help :-P
At least, such a log file should live in /var/log to follow linux conventions

@jglick jglick mentioned this pull request Apr 28, 2015
@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

ndeloof added a commit that referenced this pull request Apr 29, 2015
Make copy_reference_file quieter
@ndeloof ndeloof merged commit ecf3930 into master Apr 29, 2015
@jglick jglick deleted the quiet branch May 8, 2015 17:48
LinuxSuRen pushed a commit to alauda/jenkins-docker that referenced this pull request Sep 17, 2020
Amend Java 11 documentation to reflect the GA status of Java 11 in Jenkins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants