Remove VOLUME #55
Closed
Remove VOLUME #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The end-user should be left to determine if they want to bake configs into the image or use a volume. While I understand that the $JENKINS_HOME variable can be used to override the directory in child images, that is not conventional in official images on Docker Hub. Official builds are often used immutable building blocks for other containers and those containers are where the determination of storage should be made. Even if a child image is not made, a user can easily specify a volume on the command-line for storing state outside of a container.
|
👎 most users do use this plain image and rely on persistent JENKINS_HOME to customize installation. Also, docker user has to read the Dockerfile in all case to determine the port being exposed, so can check volumes as well. |
|
I agree with @huslage. The end-user should decide if he want use a docker volume. In my case the problem is, that i create a child image which copy some files into JENKINS_HOME. This files are owned by root and it's not possible to change it do the jenkins user. See moby/moby#3465 |
LinuxSuRen
pushed a commit
to alauda/jenkins-docker
that referenced
this pull request
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end-user should be left to determine if they want to bake configs into the image or use a volume.
While I understand that the $JENKINS_HOME variable can be used to override the directory in child images, this is not conventional in official images on Docker Hub. Official builds are often used as immutable building blocks for other containers and those containers are where the determination of storage should be made. Even if a child image is not made, a user can easily specify a volume on the command-line for storing state outside of a container.
Additionally, if a user does not look at the Dockerfile or documentation properly they could leave orphaned volumes laying around when they remove the container.