Skip to content

chore: format Jenkinsfile #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Conversation

lemeurherveCB
Copy link
Contributor

@lemeurherveCB lemeurherveCB commented Mar 25, 2025

This PR formats the Jenkinsfile pipeline as there were some bad indentations and a mix of tabs and spaces rendering the indentation unreadable in VS Code.
It also uses single quotes where double quotes aren't needed.

It finally adds a .git-blame-ignore-revs file so GitHub could ignores the format commit in the blame view:

Extracted from:

Testing done

CI (no code change)

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@lemeurherveCB lemeurherveCB requested a review from a team as a code owner March 25, 2025 19:54
@@ -0,0 +1,3 @@
# https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files#ignore-commits-in-the-blame-view
# Format Jenkinsfile: https://github.com/jenkinsci/docker/pull/2003
9ade9569a658c0ed27107915d7597fcc98d7a577
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you would normally add this in a follow up, if this PR gets squashed or rebase merged it won't be this value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Please don't squash? 😅

@timja timja merged commit 0f911e9 into jenkinsci:master Mar 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants