Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify git-lfs download #1144

Merged
merged 1 commit into from
Jul 25, 2021
Merged

Verify git-lfs download #1144

merged 1 commit into from
Jul 25, 2021

Conversation

saper
Copy link
Collaborator

@saper saper commented Jul 8, 2021

Follow-up to #1143 - just for some Docker images for review - as suggested in #1143 (comment)

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@saper saper requested a review from a team as a code owner July 8, 2021 21:48
@saper saper marked this pull request as draft July 8, 2021 21:48
@dduportal
Copy link
Contributor

Thanks a lot @saper , this method sounds good! Do you mind generalizing it to all images?

@MarkEWaite
Copy link
Contributor

I like the technique very much but have been unable to understand why the build process fails both on ci.jenkins.io and for me locally. The ci.jenkins.io failure example is at https://ci.jenkins.io/blue/organizations/jenkins/Packaging%2Fdocker/detail/PR-1144/4/pipeline#step-43-log-1514 . When running a first build, I see the same failure.

@dduportal
Copy link
Contributor

dduportal commented Jul 13, 2021

@MarkEWaite

@saper saper marked this pull request as ready for review July 14, 2021 00:16
@dduportal
Copy link
Contributor

Thanks @saper ! It looks like that gpg is missing on the alpine JDK8 as per: https://ci.jenkins.io/blue/organizations/jenkins/Packaging%2Fdocker/detail/PR-1144/16/pipeline#step-198-log-121

@saper
Copy link
Collaborator Author

saper commented Jul 25, 2021

Thanks @saper ! It looks like that gpg is missing on the alpine JDK8 as per: https://ci.jenkins.io/blue/organizations/jenkins/Packaging%2Fdocker/detail/PR-1144/16/pipeline#step-198-log-121

Yeah, love that duplication in Dockerfiles... fixed.

@dduportal
Copy link
Contributor

dduportal commented Jul 25, 2021 via email

@timja timja merged commit acbbb09 into jenkinsci:master Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants