-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify git-lfs download #1144
Verify git-lfs download #1144
Conversation
Thanks a lot @saper , this method sounds good! Do you mind generalizing it to all images? |
I like the technique very much but have been unable to understand why the build process fails both on ci.jenkins.io and for me locally. The ci.jenkins.io failure example is at https://ci.jenkins.io/blue/organizations/jenkins/Packaging%2Fdocker/detail/PR-1144/4/pipeline#step-43-log-1514 . When running a first build, I see the same failure. |
|
Thanks @saper ! It looks like that |
Yeah, love that duplication in Dockerfiles... fixed. |
Thanks ! I’m not aware of a builtin situation (i would argue that we don’t need multiple distribution for this image), but do you think it could be useful to factorize this logic to shell script (and then copy + run in the dockerfile) to centralize the version management ?
… Le 25 juil. 2021 à 11:23, Marcin Cieślak ***@***.***> a écrit :
Thanks @saper ! It looks like that gpg is missing on the alpine JDK8 as per: https://ci.jenkins.io/blue/organizations/jenkins/Packaging%2Fdocker/detail/PR-1144/16/pipeline#step-198-log-121
Yeah, love that duplication in Dockerfiles... fixed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Follow-up to #1143 - just for some Docker images for review - as suggested in #1143 (comment)