Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Windows): add JDK17 as default and JDK21 #384

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Mar 27, 2024

This PR adds Windows JDK17 and JDK21 images and set JDK17 as default image (short tags).

Closes:

Testing done

https://ci.jenkins.io/job/Packaging/job/docker-ssh-agent/job/PR-384/1/

Submitter checklist

Preview Give feedback

@lemeurherve lemeurherve marked this pull request as ready for review March 27, 2024 17:14
@lemeurherve lemeurherve requested a review from a team as a code owner March 27, 2024 17:14
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

LGTM!

@dduportal
Copy link
Contributor

I'm proceeding to merge: we'll see the result of updatecli once on the main branch.

@dduportal dduportal merged commit 30da4ec into jenkinsci:master Mar 27, 2024
5 of 6 checks passed
This was referenced Mar 27, 2024
@lemeurherve lemeurherve deleted the add-windows-jdk17-and-jdk21 branch March 29, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants