chore(updatecli/jdk21) only update Docker Bake file but not Dockerfiles as JDK17 is still the default #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es as JDK17 is still the default Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
requested review from
gounthar,
MarkEWaite and
lemeurherve
and removed request for
a team
|
The checks output looks good. Let's proceed. |
|
Created #383 : LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #375
This PR ensure that the updatecli process, when upgrading the JDK21 version, does NOT change the default value in the
Dockerfiles (see #375 (review)).Once this PR is merged, we must close #375 and delete its source branch to ensure
updatecliopens a new PR to bump JDK21 version.