-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(JDK21) Use official Temurin build for linux/s390x #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build is failing with the following error on the linux/s390x
step:
ERROR: failed to solve: eclipse-temurin:21.0.1_12-jdk-jammy: failed to resolve source metadata for docker.io/library/eclipse-temurin:21.0.1_12-jdk-jammy: no match for platform in manifest: not found
The reason is that the JDK21 need to be updated:
- https://hub.docker.com/layers/library/eclipse-temurin/21.0.1_12-jdk-jammy/images/sha256-31d6a3ca757d7aa05451e73d3549338d1f8a838a53851c35241e455eb59a39bf?context=explore does not have a
linux/s390x
image - While
21.0.2_13
has one: https://hub.docker.com/layers/library/eclipse-temurin/21.0.2_13-jre-jammy/images/sha256-23add05f25ecae9228fa5d2eb3da1028c2710060e4e4350c8d6b15787a186334?context=explore
What do you think about the following plan:
- Update the
updatecli
manifest in a subsequent PR to map to Issue #760 - updatecli changes to enable JDK updates when new JDK versions are published docker-agent#761 - It will trigger a set of JDK updates (11,17 and 21) through different PRs
- Then we'll be able to rebase the PR here to allow s390x
?
My, oh, my, I'm sorry, I went too fast and just tested the updatecli scripts, and not the image-building part. 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working since #383 is applied
👏
Available with the 5.30.0 release:
🥳 |
This is a follow-up to jenkinsci/docker-agent#772.
@MarkEWaite noted that we should use the official build versions for the architectures that have moved out of preview.
@dduportal then noted that the only one that was left was s390x.
I'm proposing this small change to remove
s390x
's JDK from the preview and start using the official Temurin builds.As
updatecli
now forces us to declare the full architecture for docker images, I also addedlinux
andwindows
where needed.The
updatecli
jdk11 action should fail, as the latest JDK11 Temurin version is only for Mac, and does not exist as a Docker image.Testing done
Submitter checklist
Link to relevant issues in GitHub or Jira