Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): correct git-lfs installation and bump of its version to 3.4.1 #318

Merged

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Sep 15, 2023

Same as jenkinsci/docker-agent#503, this PR mainly add git to the PATH before running git-lfs.exe install instead of git lfs install and unzip git-lfs archive to the correct location to avoir the error git: 'lfs' is not a git command. encountered when bumping git-lfs to its 3.4.1 version, cf #277 (comment)

Other notable changes:

  • test added to check if git-lfs (and thus git) is installed and in the PATH
  • trimprefix added to the git-lfs source in the corresponding updatecli manifest, easier to work with in files operations and in test

Testing done

Submitter checklist

Preview Give feedback

@lemeurherve
Copy link
Member Author

Will probably need #292 & #302

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Mar 11, 2024

Are these changes are needed in the proposed upgrade to 3.5.1 as well?

@lemeurherve
Copy link
Member Author

Are these changes are needed in the proposed upgrade to 3.5.1 as well?

I think so, I need to check that.

@lemeurherve lemeurherve changed the title fix(windows): bump git-lfs to 3.4.0 and fix its installation fix(windows): bump git-lfs to 3.5.1 and fix its installation Mar 22, 2024
@lemeurherve
Copy link
Member Author

updatecli is failing as one of its targets isn't in the primary branch yet.

@lemeurherve lemeurherve changed the title fix(windows): bump git-lfs to 3.5.1 and fix its installation fix(windows): use git-lfs installer and bump its version to 3.5.1 Mar 22, 2024
@lemeurherve
Copy link
Member Author

From https://ci.jenkins.io/job/Packaging/job/docker-ssh-agent/job/PR-318/21/console

00:05:07.923 Git LFS initialized.

🥳

Tests are still failing, but that's another issue (#292)

@lemeurherve lemeurherve force-pushed the fix-git-lfs-3-4-0-installation branch from 1ddeff8 to 41fae73 Compare March 27, 2024 11:21
@lemeurherve lemeurherve changed the title fix(windows): use git-lfs installer and bump its version to 3.5.1 fix(windows): correct git-lfs installation and bump of its version to 3.4.1 Mar 27, 2024
@lemeurherve lemeurherve force-pushed the fix-git-lfs-3-4-0-installation branch from 39863d9 to 448c1c9 Compare March 27, 2024 16:39
@lemeurherve lemeurherve marked this pull request as ready for review March 27, 2024 16:40
@lemeurherve lemeurherve requested a review from a team as a code owner March 27, 2024 16:40
@dduportal dduportal merged commit bc23b5d into jenkinsci:master Mar 29, 2024
5 of 6 checks passed
@lemeurherve lemeurherve deleted the fix-git-lfs-3-4-0-installation branch March 29, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants