Prevent invalid idleMinutes in retention strategy #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DockerOnceRetentionStrategy class changed the name of the field in which it stored the "timeout" value. This resulted in a lot of folks finding it had become zero, and this caused the plugin to close containers "due to inactivity" before they had a chance to become active. This change ensures that, in the event of an invalid value being provided, the class will use the default value (10 minutes), and also ensures that, from this point onwards, the value persisted is the value read (previously there was a discrepancy).
This was referenced Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DockerOnceRetentionStrategy class changed the name of the field in which it stored the "timeout" value. This resulted in some folks finding it had become zero, and this caused the plugin to close containers "due to inactivity" before they had a chance to become active.
This change ensures that, in the event of an invalid value being provided, the class will use the default value (10 minutes), and also ensures that, from this point onwards, the value persisted is the value read (previously there was a discrepancy).