Conversation
timja
force-pushed
the
add-java-17-preview
branch
from
27a9d24 to
9af5a9d
Compare
Ubuntu definitely has binutils installed in the image =/
MarkEWaite
approved these changes
Sep 26, 2021
Contributor
MarkEWaite
left a comment
MarkEWaite
left a comment
There was a problem hiding this comment.
Approved but with a question on the change to a less precise debian image version
| --output /javaruntime | ||
|
|
||
| FROM debian:bullseye-20210816 | ||
| FROM debian:bullseye |
Contributor
There was a problem hiding this comment.
I prefer the date stamp on the Docker image so that we track how close we are to the current date. Is there a compelling reason why this needs to remove the date code?
Suggested change
| FROM debian:bullseye | |
| FROM debian:bullseye-20210816 |
Member
Author
There was a problem hiding this comment.
dependabot doesn't work with it and we don't have enough maintainers.
We have a higher chance of staying up to date if we don't fix it to this tag.
but if you feel strongly I can change back
Member
Author
There was a problem hiding this comment.
can do a follow up if required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build will fail till docker-library/official-images#10945 is merged