Add metadata labels #200
Merged
Add metadata labels #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
approved these changes
Sep 13, 2021
MarkEWaite
reviewed
Sep 13, 2021
tests/agent.Tests.ps1
Outdated
| @@ -133,6 +133,12 @@ Describe "[$global:JDK $global:FLAVOR] check user access to directories" { | |||
| $exitCode | Should -Be 0 | |||
| } | |||
|
|
|||
| It 'version in docker metadata' { | |||
| $exitCode, $stdout, $stderr = Run-Program 'docker.exe' "inspect -f `"{{index .Config.Labels \`"org.opencontainers.image.version\`"}}`" $SUT_IMAGE" | |||
| $exitCode | Should -Be 0 | |||
There was a problem hiding this comment.
Is there an unbalanced grave ("`") on line 76 in the file?
There was a problem hiding this comment.
76? I haven't touched around there.
There was a problem hiding this comment.
I ran the linux tests locally, but the windows one's is just me copy pastings from jenkinsci/docker and hoping for the best, I'll start a VM if I need to
timja
commented
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #141 which was heavily conflicted