Integrate bats-assert + fix SC issues in test #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Sep 4, 2021
|
|
||
| REGEX='^([0-9]+)/(.+)$' | ||
|
|
||
| IMAGE=${IMAGE:-debian_jdk11} |
There was a problem hiding this comment.
supply a default value for when running outside of make, (like in IDE)
timja
commented
Sep 4, 2021
|
|
||
| REGEX='^([0-9]+)/(.+)$' |
MarkEWaite
approved these changes
Sep 4, 2021
2 comments? |
#194 (comment) and
I missed that your review comments were not proposing any change, just explaining the rationale for the change in that line |
timja
commented
Sep 4, 2021
timja
commented
Sep 4, 2021
This reverts commit 5824b68.
|
Created a new PR due to issues on CI, ref https://newbedev.com/git-clone-works-git-submodule-fails-permission-denied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bats-assert will give us the actual error when tests fail, unlike in #193 where the locale is broken but it just says test failed.
we already use it in https://github.com/jenkinsci/docker