Skip to content

fix Job DSL race condition #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jetersen merged 4 commits into from
Mar 22, 2019
Merged

fix Job DSL race condition #780

jetersen merged 4 commits into from
Mar 22, 2019

Conversation

@jetersen
Copy link
Member

@jetersen jetersen commented Mar 21, 2019 •
edited
Loading

Here is our checklist for contributors. No hard requirement here, just a reminder

  • Please describe what you did

fixes #619 JobDSL race condition between seed job and Job DSL Script security reported

  • Link to issue you're working on if there's a relevant one

  • Did you provide a test-case to demonstrate feature actually works / issue is fixed ?

  • Please also consider adding a line to CHANGELOG.md

@jetersen jetersen requested a review from timja March 21, 2019 03:45
This was referenced Mar 21, 2019
Closed
Closed
timja
timja reviewed Mar 21, 2019
View reviewed changes
@jetersen jetersen requested review from batmat and dwnusbaum and removed request for batmat and dwnusbaum March 21, 2019 08:04
@jenkinsci jenkinsci deleted a comment Mar 22, 2019
@jenkinsci jenkinsci deleted a comment Mar 22, 2019
@jenkinsci jenkinsci deleted a comment Mar 22, 2019
@jetersen
Copy link
Member Author

jetersen commented Mar 22, 2019 •
edited
Loading

codacy-bot comments turned off again, they are not helpful.
I have increased pull request quality expectation instead and codacy status should fail PR.

@jetersen jetersen changed the title Job dsl improvements fix Job DSL race condition Mar 22, 2019
@jetersen jetersen merged commit 920d2ff into jenkinsci:master Mar 22, 2019
@jetersen jetersen deleted the JobDSL-improvements branch March 22, 2019 06:12
@jetersen jetersen added the bugfix A PR that fixes a bug - used by Release Drafter label Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batmat batmat batmat left review comments

@timja timja timja approved these changes

Assignees

No one assigned

Labels

bugfix A PR that fixes a bug - used by Release Drafter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Race condition for dsl job queue() and dsl script security

3 participants

@jetersen @batmat @timja