Adjust for experimental Manage Jenkins UI #2756
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Before screenshots would be great to add to make easier for comparison |
timja
reviewed
Dec 16, 2025
| </l:hasAdministerOrManage> | ||
| </f:form> | ||
| <j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout" xmlns:f="/lib/form" xmlns:i="jelly:fmt" xmlns:t="/lib/hudson"> | ||
| <l:settings-subpage permissions="${app.MANAGE_AND_SYSTEM_READ}" header="${null}"> |
Member
There was a problem hiding this comment.
why pass header=null? you can just pass your own header through with a j:set ?
timja
reviewed
Dec 16, 2025
plugin/src/main/resources/io/jenkins/plugins/casc/ConfigurationAsCode/index.jelly
Outdated
Show resolved
Hide resolved
timja
reviewed
Dec 16, 2025
| <button class="jenkins-button jenkins-button--primary" | ||
| data-type="dialog-opener" | ||
| data-dialog-id="${dialogId}"> | ||
| Apply Configuration as Code file |
Member
There was a problem hiding this comment.
i18n and maybe
Suggested change
| Apply Configuration as Code file | |
| ${%Setup configuration} |
timja
reviewed
Dec 16, 2025
|
|
||
| <l:app-bar title="${it.displayName}"> | ||
| <j:if test="${!empty it.sources}"> | ||
| <button class="jenkins-button jenkins-button--primary" |
Member
There was a problem hiding this comment.
I wonder if this needs / wants to be primary. It should be very rare that you're adding a config through the UI...
timja
reviewed
Dec 16, 2025
| <gitHubRepo>jenkinsci/configuration-as-code-plugin</gitHubRepo> | ||
| <jenkins.baseline>2.504</jenkins.baseline> | ||
| <jenkins.version>${jenkins.baseline}.3</jenkins.version> | ||
| <jenkins.version>2.542-rc37822.b_14a_5941318e</jenkins.version> |
Member
There was a problem hiding this comment.
what's this need an incremental for?
Member
I'd be surprised if there's much test coverage around this page... |
timja
reviewed
Dec 17, 2025
plugin/src/main/resources/io/jenkins/plugins/casc/ConfigurationAsCode/index.jelly
Show resolved
Hide resolved
timja
reviewed
Dec 17, 2025
plugin/src/main/resources/io/jenkins/plugins/casc/ConfigurationAsCode/index.jelly
Outdated
Show resolved
Hide resolved
timja
reviewed
Dec 17, 2025
| export(out); | ||
|
|
||
| req.setAttribute("export", out.toString(StandardCharsets.UTF_8.name())); | ||
| req.setAttribute("viewExport", new ManagementLink() { |
Member
There was a problem hiding this comment.
I've been doing a dirty in Credentials plugin and just using a class that has a displayName...
Member
|
I've tested locally and it looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still rough, tests will definitely be broken:
Would be good to get thoughts.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.