stay compatible for PCT #2552
Merged
stay compatible for PCT #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCT leads to a mixture of plugin version and test-harness version. So the test will use the old `newSource` but the plugin expects `value` for the checkUrl parameter.
timja
approved these changes
Aug 27, 2024
|
Many thanks @mawinter69! Keeping PCT clean is of great importance for me as I land the EE 9 project in the coming weeks, so this is highly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCT leads to a mixture of plugin version and test-harness version. So the test will use the old
newSourcebut the plugin expectsvaluefor the checkUrl parameter.This change will stay with
newSourceas parameter but still removes the inline javascript.fixes the problems with updating the jenkins/bom as mentioned in #2551
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.