Add possibility to reload secrets from properties file with JCasC reload

[tempora-mutantur]

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

• Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or in Jenkins JIRA - Add possibility to reload secrets from properties file with JCasC reload #1555
• Did you provide a test-case? That demonstrates feature works or fixes the issue. - checked by changing the properties file

[codecov]

Codecov Report

Merging #1556 (1edab60) into master (9a40a90) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #1556      +/-   ##
============================================
- Coverage     81.02%   81.01%   -0.01%     
+ Complexity      811      810       -1     
============================================
  Files            66       66              
  Lines          2371     2370       -1     
  Branches        329      328       -1     
============================================
- Hits           1921     1920       -1     
  Misses          349      349              
  Partials        101      101              

Impacted Files	Coverage Δ	Complexity Δ
...gins/casc/impl/secrets/PropertiesSecretSource.java	80.00% <75.00%> (-1.25%)	6.00 <4.00> (-1.00)

[jetersen]

LGTM

[timja]

@tempora-mutantur any chance of a test that validates that secrets are reloaded when the properties change? codecov is complaining of a lack of test coverage here

[jetersen]

@timja The lack of test coverage is actually due to file exist if condition and catching exception which is kinda 🤷‍♂️

See codecoverage diff

[timja]

@timja The lack of test coverage is actually due to file exist if condition and catching exception which is kinda 🤷‍♂️

See codecoverage diff

well I assume we aren't testing that you can change the file and reload and it works since that didn't work before.

having the secret source not fail when the file is missing having a test wouldn't be a bad thing, not that I'm convinced it's a good feature, personally I would rather it just fails but maybe people rely on that now.

not a blocker

[jetersen]

I agree with you on the need for a properties reload test would be great.

Just correcting as to why codecov was complaining since codecov has changed the detail link to point to their homepage and not the pull request link.

[timja]

Thanks, codecov is still complaining about missing coverage on no properties file but meh!

[martinda]

T@tempora-mutantur Is there a documentation update please? I'd like to understand how to use this feature. Thanks.

[jetersen]

This is not something that is user facing @martinda next time the configure is called JCASC will read the properties again using the init method.
It should be as simply as updating the file and hit configure.

configuration-as-code-plugin/plugin/src/main/java/io/jenkins/plugins/casc/ConfigurationAsCode.java

Line 733 in ec812a8

SecretSource.all().forEach(SecretSource::init);