Require Java 11 and Jenkins 2.387.3 or newer, test with Java 21 #46
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,11 @@ | ||
| /* | ||
| See the documentation for more options: | ||
| https://github.com/jenkins-infra/pipeline-library/ | ||
| */ | ||
| buildPlugin( | ||
| forkCount: '1C', // Run 1 test process per core | ||
| useContainerAgent: true, // Set to `false` if you need to use Docker for containerized tests | ||
| configurations: [ | ||
| [platform: 'linux', jdk: 21], | ||
| [platform: 'windows', jdk: 17], | ||
| ]) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| <parent> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>plugin</artifactId> | ||
| <version>4.74</version> | ||
| </parent> | ||
| <artifactId>clover</artifactId> | ||
| <packaging>hpi</packaging> | ||
|
|
@@ -34,17 +34,16 @@ | |
| <changelist>999999-SNAPSHOT</changelist> | ||
| <gitHubRepo>jenkinsci/clover-plugin</gitHubRepo> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <jenkins.version>2.387.3</jenkins.version> | ||
|
There was a problem hiding this comment. Can you add
in the CHANGELOG.md? FYI: I'm about to release new Jenkins Clover Plugin version (4.14.0) soon. There was a problem hiding this comment. Happy to do that. Have you considered switching to release drafter so that the changelog is maintained automatically? Instructions are available with more details. Added in 7b31e02 There was a problem hiding this comment. I also changed the title of the pull request so that the release drafter will include the "Require Java 11 and Jenkins 2.387.3 or newer" in the changelog that it generates. There was a problem hiding this comment. Thank you, yes I'm working on automation and release drafter, but this is not active yet. |
||
| <clover.version>4.5.0</clover.version> | ||
| </properties> | ||
|
|
||
| <dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.jenkins.tools.bom</groupId> | ||
| <artifactId>bom-2.387.x</artifactId> | ||
| <version>2483.v3b_22f030990a_</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> | ||
|
|
@@ -78,15 +77,6 @@ | |
| </plugin> | ||
| </plugins> | ||
| </pluginManagement> | ||
| </build> | ||
| <profiles> | ||
| <profile> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have more configurations? I'd love to test it on Linux-JDK8 and Linux-JDK11, if possible.
Why? The OpenClover (org.openclover:clover) officially supports JDK7-9 only. In its latest 4.5.0 release an experimental support for JDK10-17 was added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're welcome to test more configurations, though testing Java 8 won't work with this pull request because Jenkins 2.361.1 and later do not support Java 8. Jenkins 2.361.1 and later use Java 11 byte code and support only Java 11 and Java 17.
Agents can still run builds with Java 8, but the controller itself must run with Java 11 or Java 17. The agents also must run with Java 11 or Java 17 but they can control jobs that run any any JDK version or any other tool version.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't include a test of Java 11 in this case because the Java 17 compiler is configured by the Jenkins build tools to generate Java 11 byte code. Likewise for the Java 21 compiler. They are both generating and executing Java 11 byte code, so it did not seem especially useful to create a Java 11 test configuration to generate Java 11 byte code again.
I was intentionally accepting the risk of not running tests directly on Java 11 because the Jenkins project will end its support of Java 11 in Oct 2024 when Eclipse Temurin and other Java providers are expected to end their public support of Java 11. We're only 12 months away from needing to remove that test configuration and the test configuration is already reasonably covered by the Java 17 and Java 21 configurations.
If you feel strongly that you want an explicit Java 11 configuration, I'm willing to add it. I think it is testing things that are already well tested by other configurations, but I am less attached to reducing test configurations than I am to testing Java 21 in more plugins.
Let me know your preference. Thanks again for reviewing the pull request and merging the other pull requests!