Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY-3280] Address XSS by removing some inline JEXL in JS #951

Merged
merged 1 commit into from
May 3, 2024

Conversation

daniel-beck
Copy link
Member

Address https://www.jenkins.io/security/advisory/2024-03-06/#SECURITY-3280

Resolves #942

Docs applied: https://www.jenkins.io/doc/developer/security/xss-prevention/#passing-values-to-javascript

I could have cleaned up other fields in a similar manner, but they're not required to resolve the security issue and I'd prefer to not touch the usage stats code.

Testing done

XSS before. No XSS after.

Submitter checklist

@daniel-beck daniel-beck requested a review from a team as a code owner May 3, 2024 10:04
@daniel-beck daniel-beck changed the title [SECURITY-3280] Address XSS by removing some inline Jelly in JS [SECURITY-3280] Address XSS by removing some inline JEXL in JS May 3, 2024
@basil basil added the bug label May 3, 2024
@basil basil merged commit 2162064 into jenkinsci:master May 3, 2024
15 checks passed
@daniel-beck daniel-beck deleted the SECURITY-3280 branch May 3, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stored XSS vulnerability in Build Monitor View Plugin
2 participants