Skip to content

Conversation

@harshitvasu
Copy link

Currently in the groovy script the local parameters are required and an error is thrown if absent. Users want to run tests without local as well for which the current changes will make it optional and inside the browserstackBuildWrapper they can exclude localConfig key.

@harshitvasu harshitvasu changed the title Add support for Job DSL with and without local parameters Add support for Job DSL with and without localConfig key inside browseStackBuildWrapper Feb 17, 2021
…n-plugin into Add-support-for-DSL-with-and-without-local-parameters
Copy link
Contributor

@rchougule rchougule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francisf francisf merged commit 0a8795a into jenkinsci:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants