Add workflow-job tests jar to bom #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
commented
Jul 1, 2020
Comment on lines
+106
to
+111
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-job</artifactId> | ||
| <classifier>tests</classifier> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Not sure if I need to update the tests to exercise this dependency. If so, is it enough to just add an unused import to verify that the dependency is available during compilation?
There was a problem hiding this comment.
Not necessary in this case. We just require that the sample plugin’s POM exercises all dependencies to verify that it can be done without triggering Enforcer violations or the like.
timja
approved these changes
Jul 7, 2020
jglick
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow-jobhas a tests jar that is used by at leastworkflow-multibranch, so it would be nice for that to be in the BOM.(I think there are currently only two source files in the tests jar that other plugins might use:
MockTriggerandQueryingMockTrigger.workflow-multibranchonly usesMockTrigger, and I'm not aware of any other plugins that depend on theworkflow-jobtests jar, so I could also see an argument for just copying the source code ofMockTriggertoworkflow-multibranchand removing thetestsjar fromworkflow-jobcompletely, but I figured I'd file this first and see what people think)