Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX JENKINS-42293] use <head> rooturl when there's no Stapler object to extract the root context from #868

Merged
merged 1 commit into from
Mar 1, 2017
Merged

[FIX JENKINS-42293] use <head> rooturl when there's no Stapler object to extract the root context from #868

merged 1 commit into from
Mar 1, 2017

Conversation

tfennelly
Copy link
Member

@tfennelly tfennelly commented Feb 28, 2017 •
edited by michaelneale
Loading

Description

See JENKINS-42293.

To manually test ... go to the plugin manager in classic and press the "Open Blue Ocean" button ... it should work.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
  • Ran Acceptance Test Harness against PR changes.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@tfennelly
use <head> rooturl when there's no Stapler object to extract the root…
d2c49f6 
… context from

This this is not 100% guaranteed if funky url rewriting/proxing in place.
@michaelneale
Copy link
Member

🐝 LGTM and works as advertised. ATH is happy so go for it.

@tfennelly tfennelly merged commit fdb3ace into master Mar 1, 2017
@tfennelly tfennelly deleted the JENKINS-42293 branch March 1, 2017 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-review ready-for-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfennelly @michaelneale