Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX JENKINS-41162] Remove markup from input descriptions #771

Merged
merged 8 commits into from
Feb 6, 2017
Merged

[FIX JENKINS-41162] Remove markup from input descriptions #771

merged 8 commits into from
Feb 6, 2017

Conversation

tfennelly
Copy link
Member

@tfennelly tfennelly commented Jan 31, 2017 •
edited
Loading

Description

See JENKINS-41162.

ATH Test: jenkinsci/blueocean-acceptance-test#111

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
  • Ran Acceptance Test Harness against PR changes. https://ci.blueocean.io/job/ATH-Jenkinsfile/job/master/1233/

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@reviewbybees

scherler
scherler previously requested changes Jan 31, 2017
View reviewed changes
Copy link
Collaborator

@scherler scherler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said in the chat https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML the only tag that gets excluded is script

scherler
scherler approved these changes Feb 1, 2017
View reviewed changes
Copy link
Collaborator

@scherler scherler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tfennelly tfennelly mentioned this pull request Feb 1, 2017
Closed
5 tasks
@tfennelly tfennelly force-pushed the JENKINS-41162 branch 3 times, most recently from 59e5250 to 249b13e Compare February 2, 2017 11:02
@michaelneale
Copy link
Member

michaelneale commented Feb 3, 2017 •
edited
Loading

nice one LGTM

🐝 - go for it.

@tfennelly tfennelly merged commit 7b45890 into master Feb 6, 2017
@tfennelly tfennelly deleted the JENKINS-41162 branch February 6, 2017 09:16
@tfennelly tfennelly mentioned this pull request Feb 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scherler scherler scherler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfennelly @michaelneale @scherler