Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-39763 Move new header components to blueocean-core-js for use in web and dashboard #705

Merged
merged 5 commits into from
Jan 16, 2017

Conversation

sophistifunk
Copy link
Collaborator

  • Move the header / logo components into blueocean-core-js, add storybook support
  • Make some adjustments to i18n so it doesn't block components from appearing in other modules' storybooks
  • Fix a couple of small issues in RunButton
  • Remove components from -dashboard that have been migrated to -core-js, and related stories
  • Add some excludes to storybook webpack config, which we haven't noticed because browserify is smart enough to know them already
  • Re-indent routes so they make sense

Description

See JENKINS-39763.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
  • Ran Acceptance Test Harness against PR changes.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@reviewbybees

…ybook support

 * Make some adjustments to i18n so it doesn't block components from appearing in other modules' storybooks
 * Fix a couple of small issues in RunButton
 * Remove components from -dashboard that have been migrated to -core-js, and related stories
 * Add some excludes to storybook webpack config, which we haven't noticed because browserify is smart enough to know them already
 * Re-indent routes so they make sense
@ghost
Copy link

ghost commented Jan 12, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@michaelneale
Copy link
Member

code looks ok from me (just quick look over) - perhaps @cliffmeyers could review.

Good old lint errors in the build.. I know how you love them.

What is to review here in terms of non code - just story books so far?

@sophistifunk
Copy link
Collaborator Author

Shouldn't be anything new here, besides the small cleanups and changes to i18n for testability. Just relocating the header components, and encountered a bunch of problems referencing core-js components in dashboard stories, because I initially left the old stories in dashboard as a way to make sure I'd integrated the components properly in core-js

@michaelneale
Copy link
Member

I kicked it around and things did not catch fire. Which is good... so this might be ok. Would like @cliffmeyers or @imeredith to give this a blessing code wise.

@imeredith
Copy link
Collaborator

code looks good to me 🐝

@sophistifunk sophistifunk merged commit d77c99a into master Jan 16, 2017
@sophistifunk sophistifunk deleted the feature/JENKINS-39763-move-header-components branch January 16, 2017 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants