Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WiP] First class data types / extra extension points / extensible router #362

Closed
wants to merge 35 commits into from
Closed

[WiP] First class data types / extra extension points / extensible router #362

wants to merge 35 commits into from

Conversation

kzantow
Copy link
Collaborator

@kzantow kzantow commented Jul 20, 2016 •
edited
Loading

Decription

Add some appropriate extension points to the UI to handle different job data types.

Submitter checklist

  • Change is code complete and matches issue description
  • Apppropriate unit or acceptance tests or explaination to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explaination given

@reviewbybees

kzantow and others added 30 commits June 30, 2016 15:01
@kzantow
Add component type filter for extensionPoints
7a4cc9c
@kzantow
Merge remote-tracking branch 'primary/master' into JENKINS-35860-exte…
8d3c0e0 
…nsion-point-types
@kzantow
Bump js-extensions beta version
f41a636
@kzantow
Merge remote-tracking branch 'primary/master' into JENKINS-35860-exte…
4ebf1cf 
…nsion-point-types
@kzantow
Address @tfennelly's comments:
c24dfaf 
* EXTENSIONS -> README
* more documentation for dataType vs. componentType
* modify usage of 'type' to 'dataType' for consistency
@kzantow
Merge remote-tracking branch 'primary/master' into JENKINS-35860-exte…
7e21eda 
…nsion-point-types
@kzantow
Merge remote-tracking branch 'primary/master' into JENKINS-35860-exte…
d09af3e 
…nsion-point-types
@kzantow
Split ClassMetadataStore, modify extension filtering to a common method
8983233
@kzantow
Update js-extensions version
a91b41e
@kzantow
Burned through some npm versions to get this published with a tag, d'oh
3397771
@kzantow
Separate componentType to its own file
fdbe5a6
@kzantow
Merge remote-tracking branch 'primary/master' into JENKINS-35860-exte…
479bc8e 
…nsion-point-types
@kzantow
Merge remote-tracking branch 'primary/master' into JENKINS-35860-exte…
2a808b2 
…nsion-point-types
@kzantow
Dynamic page elements based on top-level types PoC
b566f3d
@kzantow
Try dynamic routes
e063944
@kzantow
Update JDL
d90eb68
@kzantow
Migrate react router to obejcts
56d0816
@kzantow
Almost route working
20e5fd3
@kzantow
Dynamic routes working!
a856e6b
@kzantow
Add extension point for run details
dc9139a
fix: get /pipelines to render
7459fc3
fix: get top-level route and org/orgName route to redirect to 'pipeli…
cc5a1a0 
…nes' route
fix: default route for run detail redirects to 'pipeline'
250da96
add TODO
37d4ba3
@kzantow
Fix the data reference for RunDetailsPipeline
afd9abd
@kzantow
Move individual run tabs to extension point
13c91c7
@kzantow
Run details tabs extensible
a2fadf1
@kzantow
Merge branch 'san-jose-hackfest' into first-class-project-types-proto…
15d0254 
…type
@kzantow
Merge remote-tracking branch 'primary/master' into first-class-projec…
e7ba99f 
…t-types-prototype
@kzantow
Merge remote-tracking branch 'primary/master' into first-class-projec…
944ad55 
…t-types-prototype
@kzantow kzantow changed the title [WiP] First class project types prototype [WiP] First class project types Jul 20, 2016
@kzantow kzantow changed the title [WiP] First class project types [WiP] First class data types / extra extension points / extensible router Jul 20, 2016
@michaelneale
Copy link
Member

@kzantow sorry there have been some refactorings that caused the conflict (a new module).

I'll make it up to you somehow.

@tfennelly
Copy link
Member

I think merges etc are needed for this.

Also ... can we get some real examples of what the proposed changes are hoping to enable?

@michaelneale
Copy link
Member

is this still needed?

@michaelneale michaelneale mentioned this pull request Aug 25, 2016
Merged
13 tasks
@michaelneale
Copy link
Member

Closing as ancient... can bring back the goodness if needed

@i386 i386 deleted the first-class-project-types-prototype branch January 17, 2017 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kzantow @michaelneale @tfennelly