Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit dep on matrix-project #2565

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Explicit dep on matrix-project #2565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions blueocean-pipeline-api-impl/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>scm-api</artifactId>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>matrix-project</artifactId>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-durable-task-step</artifactId>
Expand Down
1 change: 1 addition & 0 deletions ...ine-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/MatrixProjectImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
this.matrixProject = folder;
}

// TODO consider @OptionalExtension(plugin = "matrix-project") and make the dep optional

Check warning on line 35 in blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/MatrixProjectImpl.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO 

NORMAL:
consider @OptionalExtension(plugin = "matrix-project") and make the dep optional
@Extension(ordinal = 1)
public static class PipelineFactoryImpl extends BluePipelineFactory{

Expand Down
4 changes: 2 additions & 2 deletions ...src/main/java/io/jenkins/blueocean/rest/impl/pipeline/analytics/MatrixAnalyticsCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import org.kohsuke.accmod.Restricted;
import org.kohsuke.accmod.restrictions.NoExternalUse;

@Extension
@Extension // TODO as in MatrixProjectImpl

Check warning on line 11 in blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/analytics/MatrixAnalyticsCheck.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO 

NORMAL:
as in MatrixProjectImpl
@Restricted(NoExternalUse.class)
public final class MatrixAnalyticsCheck implements JobAnalyticsCheck {
@Override
Expand All @@ -24,7 +24,7 @@
/**
* Exclude any jobs that are children of a MatrixProject
*/
@Extension
@Extension // TODO as in MatrixProjectImpl

Check warning on line 27 in blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/analytics/MatrixAnalyticsCheck.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO 

NORMAL:
as in MatrixProjectImpl
@Restricted(NoExternalUse.class)
public final static class ExcludeImpl implements JobAnalyticsExclude {
@Override
Expand Down
Loading