Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade plugin parent POM from 4.53 to 4.57 #2418

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Conversation

basil
Copy link
Member

@basil basil commented Mar 25, 2023

This is needed for the forthcoming PCT multi-module mode to pull in the fix for JENKINS-62658 via jenkinsci/maven-hpi-plugin#453. I tested this successfully with the latest update to the multimodule project branch of PCT, which is now doing mvn process test-classes rather than mvn install, therefore requiring the fix for JENKINS-62658. With these changes you can now successfully run mvn process-test-classes in the root directory of the repository, which was not possible with the old version of Maven HPI plugin.

To test this PR I ran:

$ git checkout blueocean-parent-1.27.3
$ git clean -fxd
$ mvn clean process-test-classes  # failed before, passes now
$ mvn -Dtest=InjectedTest -Djth.jenkins-war.path=/home/basil/src/jenkinsci/bom/target/local-test/megawar.war -DoverrideWarAdditions=true -DoverrideWar=/home/basil/src/jenkinsci/bom/target/local-test/megawar.war -Djenkins.version=2.396 -DuseUpperBounds=true -Dtest=InjectedTest hpi:resolve-test-dependencies hpi:test-hpl surefire:test # passes

CC @olamy

@basil basil requested a review from a team as a code owner March 25, 2023 17:25
@basil
Copy link
Member Author

basil commented Mar 26, 2023

Build is green.

@olamy olamy added the dependencies Pull requests that update a dependency file label Mar 26, 2023
@olamy olamy merged commit fa2f51e into jenkinsci:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants