Ceasing to test against non-block-scoped stage
#2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e method stage() on null object`
…till applicable
…ow that we know tests pass
raul-arabaolaza
approved these changes
Jan 19, 2023
car-roll
approved these changes
Jan 19, 2023
I guess this plugin is not set up to use an NPM proxy |
olamy
requested changes
Jan 19, 2023
| @@ -49,7 +49,7 @@ | |||
| <argLine>-Xmx2g -Xms2g -Djava.awt.headless=true -XX:+HeapDumpOnOutOfMemoryError -XX:+TieredCompilation -XX:TieredStopAtLevel=1</argLine> | |||
| </properties> | |||
|
|
|||
| <scm> | |||
| <scm child.scm.connection.inherit.append.path="false" child.scm.developerConnection.inherit.append.path="false" child.scm.url.inherit.append.path="false"> | |||
There was a problem hiding this comment.
why this? is it related to this PR?
There was a problem hiding this comment.
Sort of—I had problems testing this incremental build in PCT, and was hoping that fixing the deployed scms might fix it.
There was a problem hiding this comment.
Regardless of timing, this change is just matching the current recommendations: jenkinsci/archetypes#360
| @@ -15,13 +15,6 @@ | |||
| <url>https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean/doc/BlueOcean.adoc</url> | |||
| <description>Blue Ocean is a new project that rethinks the user experience of Jenkins. Designed from the ground up for Jenkins Pipeline and compatible with Freestyle jobs, Blue Ocean reduces clutter and increases clarity for every member of your team.</description> | |||
|
|
|||
| <scm> | |||
There was a problem hiding this comment.
why this? is it related to this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jenkinsci/pipeline-stage-step-plugin#94.