Skip to content

Conversation

kzantow
Copy link
Collaborator

@kzantow kzantow commented Oct 25, 2017

Description

See JENKINS-47569.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@michaelneale
Copy link
Member

ping @sophistifunk mind givin this a spin at your leisure?

@kzantow is the executor plugin also published in non snapshot form (just while we are talking finalising)

@michaelneale
Copy link
Member

is #1505 really needed to finalize?

@kzantow
Copy link
Collaborator Author

kzantow commented Oct 25, 2017

@michaelneale yes, #1505 is required, this one first. I can't publish the executor plugin until this is released in beta, really.

@michaelneale
Copy link
Member

if this passes I guess it is ok - not really code to review 👍🏻

Copy link
Collaborator

@scherler scherler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks as a version dumb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants