[JENKINS-47491] Ie11 fixes #1490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @sophistifunk @NicuPascu can one of you review? |
|
LGTM. Wasn't this already done earlier? Or should I lay off the shrooms? |
kzantow
reviewed
Oct 18, 2017
| @@ -66,6 +70,7 @@ class SvgIcon extends Component { | |||
| return ( | |||
| <svg | |||
| {...other} | |||
| focusable={focusable} | |||
There was a problem hiding this comment.
Why not just drop the option and have focusable={false}? ... but wasn't this change already done? (as @sophistifunk said)
kzantow
previously requested changes
Oct 18, 2017
|
06a1470#diff-9d44d2134191673503efac16ed92b580 @sophistifunk yeah lots of places and dropped the prop |
cliffmeyers
dismissed
kzantow’s stale review
Requested changes were implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://issues.jenkins-ci.org/browse/JENKINS-47491
PolymerElements/iron-iconset-svg#46
Any SVG elements written by SvgIcon will be put into the tab order of the page in IE11.
Expected outcome
SVG elements should not be focusable by default
Submitter checklist
Reviewer checklist