bug / JENKINS 44321 changes tab doesn't load #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s could happen if the server returned a Run object with an ommitted "changeSet" property
cliffmeyers
reviewed
May 18, 2017
| @@ -70,7 +70,7 @@ export class RunRecord extends Record({ | |||
| _class: null, | |||
| _capabilities: [], | |||
| _links: null, | |||
| changeSet: ChangeSetRecord, | |||
| changeSet: [], | |||
There was a problem hiding this comment.
changeSet is actually an array of these records. If JSON response omitted the prop, then it would get initialized to an empty ChangeSetRecord which would defeat null checking in the UI layer but still cause an exception to be thrown.
|
what is this one about? is that a go/no go @cliffmeyers ? |
|
This is a simple fix, just looking for a bee from someone. |
cliffmeyers
changed the title
|
@michaelneale renamed and linked appropriate JIRA issue. |
|
🐝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Submitter checklist
Reviewer checklist