Skip to content

Conversation

i386
Copy link
Contributor

@i386 i386 commented May 10, 2017

Description

See JENKINS-XXXXX.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
  • Ran Acceptance Test Harness against PR changes.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@vivek
Copy link
Collaborator

vivek commented May 10, 2017

LGTM 🐝 pending CI and ATH.

@daniel-beck
Copy link
Member

Package names indicate it should be named blueocean-scm-api, no? Seems inconsistent.

@vivek
Copy link
Collaborator

vivek commented May 10, 2017

@daniel-beck I think this is fine as it relates to cm specific pipeline creation apis.

@i386 ATH passes https://ci.blueocean.io/blue/organizations/jenkins/ATH-Jenkinsfile/detail/master/2387/pipeline

@michaelneale
Copy link
Member

🐝

@i386
Copy link
Contributor Author

i386 commented May 10, 2017

@i386 i386 merged commit a986f24 into master May 10, 2017
@i386 i386 deleted the topic/rename-api-module branch May 10, 2017 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants