Skip to content

Conversation

@bitwiseman
Copy link
Contributor

@bitwiseman bitwiseman commented Jul 28, 2020

This works around incompatibilities between older versions of bitbucket and bitbucket v7.x.
Added an option to let users specify their version.

Fixes #326

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@bitwiseman bitwiseman force-pushed the task/server-version branch from ddf0500 to c6eb2a3 Compare July 28, 2020 05:23
@jetersen
Copy link
Member

I would like to see JCasC tests added.

This works around incompatibilities between older versions of bitbucket and bitbucket v7.x.
Let's users specify their version.
@bitwiseman bitwiseman force-pushed the task/server-version branch from ddd9b8d to f395243 Compare July 30, 2020 01:20
@bitwiseman
Copy link
Contributor Author

Added tests and fixed "anonymous class" messages from JCasC.

@bitwiseman bitwiseman force-pushed the task/server-version branch from 8ba6677 to 8e008fc Compare July 30, 2020 01:28
There's no reason to have two separate loops over all pull requests.
@bitwiseman bitwiseman requested a review from jetersen July 30, 2020 01:39
@bitwiseman bitwiseman merged commit ef352ec into jenkinsci:master Jul 30, 2020
@bitwiseman bitwiseman deleted the task/server-version branch July 30, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto webhook creation broken for Bitbucket 6.x and earlier

4 participants