Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add valid smoke test #52

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Add valid smoke test #52

merged 1 commit into from
Jul 15, 2024

Conversation

strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Jul 15, 2024 •
edited
Loading

Based on feedback from #42 (review) and jenkinsci/jackson2-api-plugin#250

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner July 15, 2024 06:54
@strangelookingnerd strangelookingnerd merged commit f6f1448 into main Jul 15, 2024
16 of 17 checks passed
@strangelookingnerd strangelookingnerd deleted the real_smoke_test branch July 15, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@strangelookingnerd