Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ATH Docker Image) build and deploy with infra.ci.jenkins.io #905

Merged
merged 5 commits into from
Sep 7, 2022

Conversation

dduportal
Copy link
Collaborator

@dduportal dduportal commented Aug 22, 2022

Ref. jenkins-infra/helpdesk#3084

This PR adds a 2nd pipeline which goal is to build/test/deploy the ATH Docker image on the Jenkins controller infra.ci.jenkins.io.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja
Copy link
Member

timja commented Aug 22, 2022

The checks are a bit confusing in that there's soo many for the dockerfile, and then the overall build status is continuous-integration/jenkins/pr-merge which is for the docker build and not the main build.

Would it be possible to turn off the stage builds and configure the overall build status to be Docker build ?

@dduportal
Copy link
Collaborator Author

The checks are a bit confusing in that there's soo many for the dockerfile, and then the overall build status is continuous-integration/jenkins/pr-merge which is for the docker build and not the main build.

Would it be possible to turn off the stage builds and configure the overall build status to be Docker build ?

Yes of course, nice suggestion!

Thanks for the review.

This PR stays in draft, because the pipeline-library needs to be updated to allow specifying the registry (and adding the correct credentials) because jenkinsciinfra is used by default and there are no way to override it today. Should be easy.

I'll rebase this PR and set it as "ready to review" once done.

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal force-pushed the chore/helpdesk-3084 branch from 9291f3b to 1fa55bf Compare August 23, 2022 10:56
- DL4000
- DL3033 for yum packages installation
- DL3020
- DL4006
- DL3046

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal force-pushed the chore/helpdesk-3084 branch from 1fa55bf to 5426c90 Compare August 23, 2022 13:32
@dduportal
Copy link
Collaborator Author

The checks are a bit confusing in that there's soo many for the dockerfile, and then the overall build status is continuous-integration/jenkins/pr-merge which is for the docker build and not the main build.

Would it be possible to turn off the stage builds and configure the overall build status to be Docker build ?

@timja I can't easily find a way to disable the status check "per stage". I can find how to publish a custom one from pipeline though.

I'me playing around with the mulitbranch job configuration (manual changes for now) on infra.ci and just set it up like this:

Capture d’écran 2022-08-23 à 15 33 18

But it seems that the checks are kept over time. Do you have a way to clean them up or should I close this PR and open a new one with this setup?

@timja
Copy link
Member

timja commented Aug 23, 2022

if you push a new commit it should get rid of the old ones.

The stage one is probably ok, as long as the 'default' looking link doesn't point to infra.ci which most people can't access

@dduportal
Copy link
Collaborator Author

if you push a new commit it should get rid of the old ones.

Alas it does not :( I've rebased and updated the branch: still the same checks. It's not clear how to disable it.
Even renaming the check did not had any effect, I'm not sure if I did something wrong or what.

'default' looking link

Which one exactly (screenshot to clarify)?

@timja
Copy link
Member

timja commented Aug 23, 2022

continuous-integration/jenkins/pr-merge which seems to be gone now

@dduportal
Copy link
Collaborator Author

point to infra.ci which most people can't access

I'm confused between the "status checks" on the "Conversation" tabs and the "Checks" on the "Checks" tabs.
It seems that my changes of the job configuration are impacting the "Checks" tabs, which I would like to enable again so that users would be able to get the lint/build logs.

But I don't understand how to tune the "status checks" though 🤔

@dduportal dduportal marked this pull request as ready for review September 7, 2022 15:33
@dduportal dduportal requested a review from timja September 7, 2022 15:33
@dduportal
Copy link
Collaborator Author

Ready to roll, at least as a 1st version.

@timja timja added the chore label Sep 7, 2022
@timja timja enabled auto-merge (squash) September 7, 2022 15:59
@timja timja merged commit 87bd3db into jenkinsci:master Sep 7, 2022
@dduportal dduportal deleted the chore/helpdesk-3084 branch September 9, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants