Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "No verification" ssh host key verification strategy #886

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

Pldi23
Copy link
Contributor

@Pldi23 Pldi23 commented Aug 11, 2022

Proposed solution for #877

Git-client 3.11.2 and later uses ‘Known hosts file’ as default strategy (instead of git-client 3.11.1 used ‘Accept first connection'), so tests will continue to fail, I suggest to use ’No verification’ strategy for now (but please confirm that ATH only connects to local Git servers and we do not care about MitM attacks), but once #878 will be merged better to switch to ‘Accept first connection’.

Fixes #877

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@timja timja merged commit 889a315 into jenkinsci:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SECURITY-1468's solution impacts ATH builds
3 participants