Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for branch/tag comparators in when block #453

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

Alex-Weatherhead
Copy link
Contributor

@Alex-Weatherhead Alex-Weatherhead commented Nov 25, 2021

This pull-requests adds support for providing comparators for branch and tag filters in when blocks. As part of this work, functionality from the ChangeRequestDeclaration was separated out into the parent class (WhenDeclaration) to ensure that the approach was consistent with the similar work that had been done there.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Fixes #452.

@BoydL
Copy link

BoydL commented Nov 25, 2021

Can this be looked into I am experiencing an issue with using pattern matching for my tags

@nre-ableton nre-ableton changed the title Add support for branch/tag comparators in when block (#452) Add support for branch/tag comparators in when block Jan 3, 2022
Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite clueless about the declarative API and tend to stay away from issues relating to that in this repository, but you seem to at least have provided some tests etc. Beyond that, I'm unable to give a thorough review to say if something has been overlooked or missed.

@nre-ableton nre-ableton merged commit 0e94e35 into jenkinsci:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for branch/tag comparators in when block
3 participants