Make closure to registerAllowedMethod optional #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, you had to specify the closure to registerAllowedMethod, even if you wanted the default behaviour. For this reason, a big block of registerAllowedMethod calls has a lot of noise, because each line ends with `, null)`. This chang makes it possible to omit. Technically, this change is not API-compatible, but I think the benefits outweigh the small amount of corner-cases this might break...
nre-ableton
reviewed
Mar 26, 2020
There was a problem hiding this comment.
I think that 5a0e631 should be dropped. Unless I'm missing something, the execution will not be the same.
At least the captured call tree from the test |
|
Dropped the commit for now, I'll try to find more evidence for my claims :D |
nre-ableton
approved these changes
Mar 27, 2020
|
Nice! Merged. |
stchar
pushed a commit
that referenced
this pull request
Mar 30, 2020
stchar
pushed a commit
that referenced
this pull request
Mar 30, 2020
stchar
pushed a commit
that referenced
this pull request
Apr 1, 2020
stchar
added a commit
that referenced
this pull request
Apr 3, 2020
feat(declarative): apply changes done in #191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration - I'm fine if this is considered too dangerous 😺 - just close and forget the pull request then
Before, you had to specify the closure to registerAllowedMethod, even
if you wanted the default behaviour. For this reason, a big block of
registerAllowedMethod calls has a lot of noise, because each line ends
with
, null). This change makes it possible to omit.Technically, this change is not API-compatible, but I think the benefits
outweigh the small amount of corner-cases this might break...