Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade go version from 1.16 to 1.23 #805

Merged
merged 2 commits into from
Dec 20, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
upgrade actions/upload-artifact to v4
LinuxSuRen committed Dec 20, 2024
commit 0c3cec31858e6fdc9932353217f28e0524ebe9d6
4 changes: 2 additions & 2 deletions .github/workflows/pull-request.yaml
Original file line number Diff line number Diff line change
@@ -22,12 +22,12 @@ jobs:
with:
args: release --snapshot --clean
- name: Upload Artifact for darwin
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: jcli-darwin-amd64
path: release/jcli-darwin-amd64.tar.gz
- name: Upload Artifact for linux
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: jcli-linux-amd64
path: release/jcli-linux-amd64.tar.gz

Unchanged files with check annotations Beta

Size int64
}
type JobWithArtifacts struct {

Check failure on line 18 in client/artifacts.go

GitHub Actions / Lint

exported type JobWithArtifacts should have comment or be unexported
Artifacts []JobArtifact `json:"artifacts"`
}
func (j JobWithArtifacts) GetArtifacts() (artifacts []Artifact) {

Check failure on line 22 in client/artifacts.go

GitHub Actions / Lint

exported method JobWithArtifacts.GetArtifacts should have comment or be unexported
for _, a := range j.Artifacts {
artifacts = append(artifacts, Artifact{
ID: a.FileName,
return
}
type JobArtifact struct {

Check failure on line 33 in client/artifacts.go

GitHub Actions / Lint

exported type JobArtifact should have comment or be unexported
RelativePath string `json:"relativePath"`
FileName string `json:"fileName"`
}