Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e-test go version to 1.16 #599

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Conversation

yJunS
Copy link
Member

@yJunS yJunS commented Jul 29, 2021

Make sure that you've checked the boxes below before you submit PR:

Always

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Written well with PR title, we generate the release notes base on that

For the bug fixes or features only

  • Quality Gate Passed. Change this URL to your PR.
  • The coverage is xxx on the new lines
  • I've tested it by manual in the following platform
    • MacOS
    • Linux
    • Windows
  • Unit Test covered
  • e2e Test covered

@linuxsuren-bot
Copy link

Welcome @yJunS! It looks like this is your first PR to jenkins-zh/jenkins-cli 🎉

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #599 (5840e04) into master (c1846ac) will not change coverage.
The diff coverage is n/a.

❗ Current head 5840e04 differs from pull request most recent head c40b865. Consider uploading reports for the commit c40b865 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #599   +/-   ##
=======================================
  Coverage   38.46%   38.46%           
=======================================
  Files          13       13           
  Lines         286      286           
=======================================
  Hits          110      110           
  Misses        164      164           
  Partials       12       12           
Flag Coverage Δ
unittests 38.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1846ac...c40b865. Read the comment docs.

Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to upgrade the version, then we should upgrade it from all places instead of just the e2e tests.

@yJunS
Copy link
Member Author

yJunS commented Jul 30, 2021

If we want to upgrade the version, then we should upgrade it from all places instead of just the e2e tests.

OK. I already updated

@LinuxSuRen
Copy link
Member

and here

go 1.14

@yJunS
Copy link
Member Author

yJunS commented Jul 30, 2021

and here

go 1.14

Already updated.

Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@LinuxSuRen LinuxSuRen merged commit 2a53ebe into jenkins-zh:master Jul 30, 2021
jxr98 pushed a commit to jxr98/jenkins-cli that referenced this pull request Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants