-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update e2e-test go version to 1.16 #599
Conversation
Welcome @yJunS! It looks like this is your first PR to jenkins-zh/jenkins-cli 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
=======================================
Coverage 38.46% 38.46%
=======================================
Files 13 13
Lines 286 286
=======================================
Hits 110 110
Misses 164 164
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to upgrade the version, then we should upgrade it from all places instead of just the e2e tests.
OK. I already updated |
and here Line 3 in c1846ac
|
Already updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Make sure that you've checked the boxes below before you submit PR:
Always
For the bug fixes or features only