Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow Config Migration #4331

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

daveconde
Copy link
Contributor

@daveconde daveconde commented Jun 19, 2019

This PR adds the jx step scheduler config migrate command. This will create a series of pipeline scheduler custom resources that are linked to the SourceRepositories for each of your projects. They can then be used with jx step scheduler config apply to generate and apply the prow config.

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #4331 into master will decrease coverage by 35.34%.
The diff coverage is 1.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #4331       +/-   ##
==========================================
- Coverage   41.92%   6.57%   -35.35%     
==========================================
  Files         803     685      -118     
  Lines      100760   91459     -9301     
==========================================
- Hits        42246    6017    -36229     
- Misses      55189   85024    +29835     
+ Partials     3325     418     -2907
Flag Coverage Δ
#e2e 6.57% <1.55%> (-0.06%) ⬇️
#integration ?
Impacted Files Coverage Δ
pkg/client/openapi/core/openapi_generated.go 0% <0%> (-100%) ⬇️
pkg/pipelinescheduler/builder.go 0% <0%> (-76.14%) ⬇️
pkg/prow/prow.go 0% <0%> (-75.14%) ⬇️
pkg/pipelinescheduler/generator.go 0% <0%> (-71.6%) ⬇️
.../cmd/step/scheduler/step_scheduler_config_apply.go 21.66% <0%> (-38.34%) ⬇️
pkg/apis/jenkins.io/v1/zz_generated.deepcopy.go 0% <0%> (-32.4%) ⬇️
pkg/pipelinescheduler/scheduler_builder.go 0% <0%> (ø)
pkg/pipelinescheduler/config_builder.go 0% <0%> (-83.55%) ⬇️
pkg/cmd/step/scheduler/step_scheduler_config.go 60% <100%> (+2.1%) ⬆️
...md/step/scheduler/step_scheduler_config_migrate.go 25.37% <25.37%> (ø)
... and 408 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7fdfc...9dea362. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #4331 into master will increase coverage by 1.99%.
The diff coverage is 78.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4331      +/-   ##
==========================================
+ Coverage   42.12%   44.11%   +1.99%     
==========================================
  Files         811      813       +2     
  Lines      101329   102447    +1118     
==========================================
+ Hits        42686    45199    +2513     
+ Misses      55226    53522    -1704     
- Partials     3417     3726     +309
Flag Coverage Δ
#e2e 30.91% <12.48%> (+24.28%) ⬆️
#integration 42.49% <78.43%> (+0.61%) ⬆️
Impacted Files Coverage Δ
pkg/client/openapi/core/openapi_generated.go 100% <100%> (ø) ⬆️
pkg/pipelinescheduler/testhelpers/helpers.go 100% <100%> (ø) ⬆️
pkg/pipelinescheduler/builder.go 85.8% <100%> (+9.67%) ⬆️
pkg/cmd/step/scheduler/step_scheduler_config.go 60% <100%> (+2.1%) ⬆️
pkg/prow/prow.go 71.42% <44%> (-3.71%) ⬇️
.../cmd/step/scheduler/step_scheduler_config_apply.go 60% <60%> (ø) ⬆️
...md/step/scheduler/step_scheduler_config_migrate.go 61.19% <61.19%> (ø)
pkg/pipelinescheduler/generator.go 67.09% <65.58%> (-4.51%) ⬇️
pkg/apis/jenkins.io/v1/zz_generated.deepcopy.go 41.32% <79.31%> (+8.92%) ⬆️
pkg/pipelinescheduler/scheduler_builder.go 83.99% <83.99%> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a71de...3511b92. Read the comment docs.

@daveconde daveconde force-pushed the dconde-3919-migration branch from 90799a0 to 54533af Compare June 20, 2019 08:46
@daveconde daveconde force-pushed the dconde-3919-migration branch 8 times, most recently from 5c84319 to cce8c8f Compare June 24, 2019 14:26
@daveconde daveconde changed the title WIP - Prow Config Migration Prow Config Migration Jun 24, 2019
fixes jenkins-x#3919

Signed-off-by: David Conde <dconde@cloudbees.com>
@daveconde daveconde force-pushed the dconde-3919-migration branch from cce8c8f to 3511b92 Compare June 24, 2019 17:12
}

var (
stepSchedulerConfigMigrateLong = templates.LongDesc(`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks out of date?

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmuir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 0229801 into jenkins-x:master Jun 24, 2019
@daveconde daveconde deleted the dconde-3919-migration branch June 25, 2019 08:09
daveconde pushed a commit to daveconde/jx that referenced this pull request Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants