-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not try to create the environments if they already exist #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in GitOps mode the behavior is different and re-installation fails ``` Creating default staging and production environments Using xxx environment git owner in batch mode. error: creating the environments: failed to create staging environment in namespace jx: Environment staging already exists! ``` Signed-off-by: Carlos Sanchez <carlos@apache.org>
/assign @jstrachan |
ccojocar
approved these changes
May 19, 2019
/test all |
/test integration |
Signed-off-by: Carlos Sanchez <carlos@apache.org>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, ccojocar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
daveconde
pushed a commit
to daveconde/jx
that referenced
this pull request
Apr 7, 2020
…x#4008) * Do not try to create the environments if they already exist in GitOps mode the behavior is different and re-installation fails ``` Creating default staging and production environments Using xxx environment git owner in batch mode. error: creating the environments: failed to create staging environment in namespace jx: Environment staging already exists! ``` Signed-off-by: Carlos Sanchez <carlos@apache.org> * Fix compilation issue Signed-off-by: Carlos Sanchez <carlos@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in GitOps mode the behavior is different and re-installation fails
Signed-off-by: Carlos Sanchez carlos@apache.org
Submitter checklist
Description
Special notes for the reviewer(s)
Which issue this PR fixes
fixes #