Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to create the environments if they already exist #4008

Merged
merged 2 commits into from
May 20, 2019

Conversation

carlossg
Copy link

in GitOps mode the behavior is different and re-installation fails

Creating default staging and production environments
Using xxx environment git owner in batch mode.
error: creating the environments: failed to create staging environment in namespace jx: Environment staging already exists!

Signed-off-by: Carlos Sanchez carlos@apache.org

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

in GitOps mode the behavior is different and re-installation fails

```
Creating default staging and production environments
Using xxx environment git owner in batch mode.
error: creating the environments: failed to create staging environment in namespace jx: Environment staging already exists!
```

Signed-off-by: Carlos Sanchez <carlos@apache.org>
@carlossg
Copy link
Author

/assign @jstrachan

@ccojocar
Copy link
Contributor

/test all

@abayer
Copy link
Contributor

abayer commented May 20, 2019

/test integration

Signed-off-by: Carlos Sanchez <carlos@apache.org>
@abayer
Copy link
Contributor

abayer commented May 20, 2019

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit a5f3521 into jenkins-x:master May 20, 2019
daveconde pushed a commit to daveconde/jx that referenced this pull request Apr 7, 2020
…x#4008)

* Do not try to create the environments if they already exist

in GitOps mode the behavior is different and re-installation fails

```
Creating default staging and production environments
Using xxx environment git owner in batch mode.
error: creating the environments: failed to create staging environment in namespace jx: Environment staging already exists!
```

Signed-off-by: Carlos Sanchez <carlos@apache.org>

* Fix compilation issue

Signed-off-by: Carlos Sanchez <carlos@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants