Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3738 - pinning versions of all code generators #3779

Merged
merged 6 commits into from
May 3, 2019
Merged

Issue #3738 - pinning versions of all code generators #3779

merged 6 commits into from
May 3, 2019

Conversation

hferentschik
Copy link

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Special notes for the reviewer(s)

Now all code generators are fixed in version. Also, the lint job does now properly run and not silently ignore errors.

Which issue this PR fixes

fixes # 3738

@hferentschik hferentschik force-pushed the issue-3738 branch 2 times, most recently from 71d06bd to 83f5a05 Compare April 29, 2019 07:35
@hferentschik
Copy link
Author

/test lint

@hferentschik hferentschik force-pushed the issue-3738 branch 2 times, most recently from abf1d81 to 1f5d78d Compare April 29, 2019 09:40
@hferentschik
Copy link
Author

/retest

@hferentschik
Copy link
Author

/test lint

2 similar comments
@hferentschik
Copy link
Author

/test lint

@hferentschik
Copy link
Author

/test lint

@hferentschik
Copy link
Author

/test lint

1 similar comment
@hferentschik
Copy link
Author

/test lint

@hferentschik
Copy link
Author

/test bdd

@hferentschik hferentschik changed the title [WIP] Issue 3738 - pinning versions of all code generators Issue #3738 - pinning versions of all code generators Apr 30, 2019
@hferentschik hferentschik requested a review from pmuir April 30, 2019 07:19
@pmuir
Copy link
Contributor

pmuir commented May 1, 2019

/test all

1 similar comment
@hferentschik
Copy link
Author

/test all

houndci-bot
houndci-bot reviewed May 2, 2019
View reviewed changes
cmd/codegen/util/files.go Outdated
return nil
}

// Download a file from the given URL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment on exported function DownloadFile should be of the form "DownloadFile ..."

cmd/codegen/util/files.go
return nil
}

// credit https://gist.github.com/r0l1/92462b38df26839a3ca324697c8cba04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment on exported function CopyFile should be of the form "CopyFile ..."

cmd/codegen/util/files.go
return nil
}

func FileExists(path string) (bool, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported function FileExists should have comment or be unexported

cmd/codegen/util/cli.go Outdated

var (
fatalErrHandler = fatal
ErrExit = fmt.Errorf("exit")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported var ErrExit should have comment or be unexported

cmd/codegen/util/cli.go
)

const (
DefaultErrorExitCode = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported const DefaultErrorExitCode should have comment (or a comment on this block) or be unexported

@hferentschik hferentschik force-pushed the issue-3738 branch 4 times, most recently from 980cf20 to bdb9333 Compare May 2, 2019 09:55
@hferentschik
Copy link
Author

@pmuir all tests passed

@hferentschik
fix: making sure run-all-checks.sh captures all failures
471fd2d 
Signed-off-by: Hardy Ferentschik <hardy@ferentschik.de>
@hferentschik
fix: pinning kube-openapi and gen-apidocs to fixed versions
d5d9266 
- refactoring options setup for generators

fixes issue jenkins-x#3738

Signed-off-by: Hardy Ferentschik <hardy@ferentschik.de>
@hferentschik
chore: running code generation using latest generators
2ea88ed 
Signed-off-by: Hardy Ferentschik <hardy@ferentschik.de>
@hferentschik
fix: ensuring projects lives under GOPATH for running linting tasks
5a8a37c 
Signed-off-by: Hardy Ferentschik <hardy@ferentschik.de>
@hferentschik
fix: make sure that codegen does not get rebuild on each generate call
7077f3d 
Signed-off-by: Hardy Ferentschik <hardy@ferentschik.de>
@hferentschik
fix: making codegen independent of jx
d74dfc1 
Signed-off-by: Hardy Ferentschik <hardy@ferentschik.de>
@pmuir
Copy link
Contributor

pmuir commented May 3, 2019

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmuir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 1f93c0a into jenkins-x:master May 3, 2019
@hferentschik hferentschik deleted the issue-3738 branch August 23, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@pmuir pmuir Awaiting requested review from pmuir

Assignees

@pmuir pmuir

@daveconde daveconde

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hferentschik @pmuir @jenkins-x-bot @houndci-bot @daveconde